Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[assert helpers] react-dom (pt2) #31902

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

rickhanlonii
Copy link
Member

Converts more react-dom tests

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ❌ Failed (Inspect) Jan 2, 2025 8:29pm

@react-sizebot
Copy link

react-sizebot commented Dec 24, 2024

Comparing: d8a08f8...66d867f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 512.42 kB 512.42 kB = 91.59 kB 91.59 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 517.20 kB 517.20 kB = 92.45 kB 92.45 kB
facebook-www/ReactDOM-prod.classic.js = 594.22 kB 594.22 kB = 104.67 kB 104.67 kB
facebook-www/ReactDOM-prod.modern.js = 584.49 kB 584.49 kB = 103.13 kB 103.13 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against c5da570

@rickhanlonii rickhanlonii merged commit 7c11aad into facebook:main Jan 2, 2025
186 of 187 checks passed
rickhanlonii added a commit that referenced this pull request Jan 2, 2025
Converts more react-dom tests
@rickhanlonii rickhanlonii deleted the rh/asserts/react-dom-pt2 branch January 2, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants